Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to Giveaways Extractor to only extract from the current giveaway onwards #145

Closed
randomname42 opened this issue Nov 8, 2017 · 1 comment

Comments

@randomname42
Copy link

This is hard to describe (I hope the title wasn't too confusing) so I'll give an example. There's been an ongoing community train that keeps getting new carts every day here. Starting over from the beginning on such a long train obviously isn't desirable.

In this particular train many people are doing Back/Previous links as well as Next for the next cart, which I think is confusing ESGST because of the multiple links in those giveaways. It's not extracting the Next giveaways link (I'll give a concrete example in a moment) but rather seems to be going backwards to previous carts because of those Previous links. My guess: Maybe because those Previous links come before the Next links, so ESGST finds the Previous links first and uses those?

I have seen plenty of other trains do that previous/next thing too, but this is the first one where I've come back to it on another day to extract the rest of the giveaways.

And for a specific example, if you try to use the extractor on this page, the next giveaway on the train is City Climber. That should show up next in the extraction. But City Climber doesn't show up in the first 50 giveaways extracted from the giveaway that I linked.

In fact City Climber didn't even show up after 150 giveaways were extracted, so I gave up at that point. I don't know any way I can get the extractor to start extracting the giveaways in right direction (higher numbered carts, which are what I haven't seen yet). The train is ending soon so I guess all I can do is click through manually from here on.

I do have some ideas for fixes. For trains where each cart is numbered (like this one was) maybe ESGST could check to see if those cart numbers are going up or down in the the links it checks, and if someone starts not from the first cart, it could give an option whether they wanted to go backwards or forward.

In cases where carts aren't numbered in the giveaways themselves, checking the link description text for commonly used things like "previous, back, next, forward, <, <<, >, or >>" could allow ESGST to know what direction the links are heading.

Also, usually the Back link is farthest to the left and the Next link is farthest to the right, so maybe that could be a fallback general assumption to make if all of those other checks fail.

@rafaelgomesxyz
Copy link
Owner

The issue is the extractor extracts the entire train, not just the train from a specific point onwards. So wherever you are in the train it will go back all the way to the first cart before proceeding to the next one.

So it's not a bug, but its default behavior. I'll see about adding an option to extract only onwards from a specific point.

@rafaelgomesxyz rafaelgomesxyz changed the title Train extractor doesn't know what direction to check links if you start in the middle of a train (train cart direction awareness issue) Add option to Giveaways Extractor to only extract from the current giveaway onwards Nov 12, 2017
@rafaelgomesxyz rafaelgomesxyz added this to the 7.7.4 milestone Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants