Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug in Game Categories that happens when the Steam store does not have information about the base game of a DLC #149

Closed
darkki opened this issue Nov 9, 2017 · 0 comments
Labels

Comments

@darkki
Copy link

darkki commented Nov 9, 2017

ESGST only seems to load 3-10 tags/ratings, etc. and when i reloaded more now to test it does not load them at all!

Edit: It seems to load them fine on other places like Wishlist and Group but not on All

Previously it was like this:

esgst-bug

This is what i get from console (Using latest Chrome)

2-content-core.js:10 Domain: www.steamgifts.com
www.steamgifts.com/:118 GET https://cdn.steamgifts.com/js/prebid_v3.js net::ERR_BLOCKED_BY_CLIENT
(index):157 GET https://www.googletagservices.com/tag/js/gpt.js net::ERR_BLOCKED_BY_CLIENT
(anonymous) @ (index):157
(anonymous) @ (index):158
VM1311:641 Assuming dark theme and adjusting colors
(index):171 GET https://www.google-analytics.com/analytics.js net::ERR_CONNECTION_REFUSED
(anonymous) @ (index):171
(anonymous) @ (index):172
(index):1 Mixed Content: The page at 'https://www.steamgifts.com/' was loaded over HTTPS, but requested an insecure image 'http://cdn.edgecast.steamstatic.com/steamcommunity/public/images/avatars/a8/a85ef58605e3ca90da019ea28789805df29ba9d9_medium.jpg'. This content should also be served over HTTPS.
VM1308:26560 Uncaught TypeError: Cannot read property 'null' of null
at response (eval at E_c (:3:298), :26560:84)
at Function.onload (eval at E_c (:3:298), :34605:25)
at :2:479
at eval (eval at exec_fn (:2:27), :31:101)
response @ VM1308:26560
onload @ VM1308:34605
(anonymous) @ VM1163:2
(anonymous) @ VM1268:31
setTimeout (async)
(anonymous) @ VM1163:2
b.safeWindow.(anonymous function) @ VM1163:8
k @ VM1268:31
(anonymous) @ VM1268:36
(anonymous) @ VM1268:18
(anonymous) @ VM1163:2
c @ VM1163:2
message @ VM1268:18
message @ VM1268:19
(anonymous) @ VM1268:71
Y @ VM1163:9
e @ content.js:6
send @ content.js:8
postMessage @ content.js:8
(anonymous) @ content.js:17
EventImpl.dispatchToListener @ VM1152 extensions::event_bindings:403
publicClassPrototype.(anonymous function) @ VM1158 extensions::utils:138
EventImpl.dispatch_ @ VM1152 extensions::event_bindings:387
EventImpl.dispatch @ VM1152 extensions::event_bindings:409
publicClassPrototype.(anonymous function) @ VM1158 extensions::utils:138
dispatchOnMessage @ VM1159 extensions::messaging:392
(index):1 Mixed Content: The page at 'https://www.steamgifts.com/' was loaded over HTTPS, but requested an insecure image 'http://cdn.edgecast.steamstatic.com/steamcommunity/public/images/avatars/ca/cab375b9abebc9fe687552564d2485105a0df732_medium.jpg'. This content should also be served over HTTPS.
VM1308:26560 Uncaught TypeError: Cannot read property 'null' of null
at response (eval at E_c (:3:298), :26560:84)
at Function.onload (eval at E_c (:3:298), :34605:25)
at :2:479
at eval (eval at exec_fn (:2:27), :31:101)
response @ VM1308:26560
onload @ VM1308:34605
(anonymous) @ VM1163:2
(anonymous) @ VM1268:31
setTimeout (async)
(anonymous) @ VM1163:2
b.safeWindow.(anonymous function) @ VM1163:8
k @ VM1268:31
(anonymous) @ VM1268:36
(anonymous) @ VM1268:18
(anonymous) @ VM1163:2
c @ VM1163:2
message @ VM1268:18
message @ VM1268:19
(anonymous) @ VM1268:71
Y @ VM1163:9
e @ content.js:6
send @ content.js:8
postMessage @ content.js:8
(anonymous) @ content.js:17
EventImpl.dispatchToListener @ VM1152 extensions::event_bindings:403
publicClassPrototype.(anonymous function) @ VM1158 extensions::utils:138
EventImpl.dispatch_ @ VM1152 extensions::event_bindings:387
EventImpl.dispatch @ VM1152 extensions::event_bindings:409
publicClassPrototype.(anonymous function) @ VM1158 extensions::utils:138
dispatchOnMessage @ VM1159 extensions::messaging:392

@rafaelgomesxyz rafaelgomesxyz added this to the 7.7.3 milestone Nov 10, 2017
@rafaelgomesxyz rafaelgomesxyz changed the title ESGST only loads few game tags/ratings Fix a bug in Game Categories that happens when the Steam store does not have information about the base game of a DLC Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants