-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to make popups static #200
Comments
What do you mean by fix? They are supposed to move, otherwise they won't be centered. |
I mean fix the left top corner to one place so that if the window needs to be longer, it will change its size towards the bottom or right. |
It may be better to set fixed width for the pop up. It would fixed the moving to left/right at least. |
The problem with setting a fixed width for the popup is that some popups are small while others are big, so that wouldn't look good. Or do you mean fixing the width only for the menu popup? |
I don't like the moving in a lot of pop ups but in the settings it is most visible so even the manual fixing of just the settings window would be good. I think the main problem is the automatic vertical centering. Maybe just disabling it would help it. I would try to measure the distance from the top of the page and left side of the page to the pop up and fix the window in the position. It would be similar to the giveaways filters, for example. There it is fixed to the element above it so if you open it, it will open down and it looks good. |
The problem with a fixed distance is that for some popups it would look very bad at the top left corner of the screen (everything looks better centered), but if that doesn't bother you I can add it as an option. |
It would look exactly like before the autocenter function moves the window. So I didn't have to draw it for you so that you knew what I meant but you can just look at it. I did screenshots and it looks quite good in the settings. So just disabling the autocentering should solve it for me in the settings. You can try it just in the settings and we will see if it is usable. |
The problem is that to grow towards the bottom/right, it has to be placed in the top left corner, otherwise there is a risk that there isn't enough room at the right side. I added an option to make popups static at the top left corner to the latest dev version, let me know if that works well for you. |
The static pop ups are fine but I don't like them because they are not centered. I already can show you what exactly I mean. You would have to set a fixed width, min-height and center the pop ups. Check how it works in FB Purity extension here. |
It would look horrible for small popups. |
Small pop ups would have to have smaller width. |
The problem is there is no way to know the width of a popup. |
You can set some default width for each kind of the popup and the text will wrap to more lines in case the text is longer. It would look milion times better then a popup that is moving and increasing its weight to ridiculous dimensions on widescreen monitors. For example, the Sent Unsent Gifts popup behaves like this. |
I'm not interested in checking each kind of popup and setting a width for it at the moment, I believe there are close to 100 different kinds of popups in the script. I disagree, the moving popup is much better than the static one for me, but for those who are annoyed by it the current static popup does a pretty good job, not having it at the center is a minor annoyance. |
I'll see if I can do it generically. |
Added an option to the latest dev version to set a fixed width, see how it is. It applies to all popups, but perhaps it's not too bad for small popups. |
It looks totally amazing! This is how popups should behave! And the fact the the popups are not vertically centered is also amazing, because one doesn't have to bend their head when they are looking to the popups. I tested it with Check for whitelists, GA extractor and Settings and it is really good. I like your solution that one can set his own width. I didn't change the default width and I think it is OK for me with 1920/1080 monitor so I think the default width is good for most of people. Great work! I am finally satisfied! |
Glad to hear it! |
Please fix the moving pop ups. It's totally crazy.
The text was updated successfully, but these errors were encountered: