Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight game ids for games that are not in the Steam API when syncing and therefore cannot be converted to a name #234

Closed
gizellos opened this issue Nov 21, 2017 · 5 comments

Comments

@gizellos
Copy link

I did ESGST sync and I can see quite strange things there. It may not be even bugs of the script, though, but I will rather mention it.

  1. I can see numbers instead of names. Some numbers are not translated to their names.
  2. All the numbers go to the same page - so for me as an end user they are duplicates. But I guess it is a matter of Steam API and the script cannot tell that they are redirected to the same page.
  3. The text "Alt Account - Calzonek" IMHO should not be there after the sync is done because it is an indicator while the alt account is being scanned. Now it looks as if I was supposed to click on it again to scan the alt account. I suggest to hid the text after the sync is finished.

Or you can do it as a status message that is visible also after the sync, but you would have to add there also text about the normal account and add there something like "was synced" or "sync complete". So there would be two messages in the end.

"You account was synced"
"Alt Account - Calzonek was synced"

2017-11-21_162844

@rafaelgomesxyz
Copy link
Owner

They are probably DLCs or something that are not reported by the Steam API, as you can see here: http://store.steampowered.com/api/appdetails?appids=349181 It would be nice to have a message next to those numbers to inform that they are not on the API though, that could help identify if there was a bug while retrieving the name or if there was no name to retrieve.

I'll make another issue for the status thing, because putting 2+ suggestions in the same issue doesn't work well with the new milestones method I use to fix issues.

@rafaelgomesxyz rafaelgomesxyz changed the title Added apps in sync - some items are still numbers Highlight game ids for games that are not in the Steam API when syncing and therefore cannot be converted to a name Nov 21, 2017
@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented Nov 21, 2017

By the way, you mean the second "alt account", right? Because the first one is a separator and should not be removed. I don't like the idea of adding a message saying that it was synced, when the button goes back to "Sync" it means the sync has ended (maybe I should just remove the button once it's done), so I'll just remove that second text.

@rafaelgomesxyz
Copy link
Owner

Actually, how did two texts even appear? I just tried syncing with an alt account and I got only one text: the one before added apps.

@gizellos
Copy link
Author

Sorry, I didn't want to make the screen when there was the two text. I just tried to do the sync again to be really sure that the second possible sync is not only for the alt account. So I just clicked on the Sync button, it made the second sync and the other text appeared. It is not there normally.

@rafaelgomesxyz
Copy link
Owner

Ah ok, that's normal then.

@rafaelgomesxyz rafaelgomesxyz added this to the 7.9.0 milestone Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants