Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search filters to the settings menu #253

Closed
gizellos opened this issue Nov 23, 2017 · 5 comments
Closed

Add search filters to the settings menu #253

gizellos opened this issue Nov 23, 2017 · 5 comments

Comments

@gizellos
Copy link

It would be really helpful if there was search field with suggestions in the ESGST settings. The suggestions would be links leading to the particular settings.

It seems that the results would have to be often a combination of all levels if it was needed. For example, I would type there the word giveaways and the first results would be: General -> Endless Scrolling -> Enable for giveaways in the main page.

@killergege
Copy link

I would like that. At least display a big border/visual cues around the items that match the search term + autoscroll to the first one ?

@rafaelgomesxyz rafaelgomesxyz added this to the 7.9.0 milestone Nov 23, 2017
@rafaelgomesxyz rafaelgomesxyz changed the title Search field with suggestions in the ESGST settings Add search filters to the settings menu Nov 23, 2017
@gizellos
Copy link
Author

Looks good but doesn't work for me because I have all settings collapsed. :(

@rafaelgomesxyz
Copy link
Owner

It does work, you just need to expand the settings to see the results. Would you like the search to automatically expand them?

@gizellos
Copy link
Author

Yes, expand it automatically, please.

@gizellos
Copy link
Author

gizellos commented Nov 25, 2017

It doesn't work even if I collapse it. I have these error there:

2 esgst.js:28924 Uncaught TypeError: Cannot read property 'classList' of null
    at unhideSmFeature (esgst.js:28924)
    at unhideSmFeature (esgst.js:28927)
    at HTMLInputElement.filterSm (esgst.js:28893)

16 esgst.js:28918 Uncaught TypeError: Cannot read property 'classList' of null
    at filterSmFeature (esgst.js:28918)
    at filterSmFeature (esgst.js:28909)
    at filterSmFeature (esgst.js:28909)
    at HTMLInputElement.filterSm (esgst.js:28890)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants