Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that does not persist some settings #677

Closed
Tristar7 opened this issue May 12, 2018 · 4 comments
Closed

Fix a bug that does not persist some settings #677

Tristar7 opened this issue May 12, 2018 · 4 comments
Labels

Comments

@Tristar7
Copy link

Tristar7 commented May 12, 2018

Changing 'Show page divisors' option simply doesn't save and directly reverts to its previous state. Can be seen just by closing and reopening ESGST options.
If it was enabled before (either before version update or through setting import) it stays enabled.
Only on Chrome/Opera, works on FF.
No errors in console.

@rafaelgomesxyz
Copy link
Owner

What version are you using on Chrome/Opera? I really don't think this has anything to do with the browser, but with the version you're using and how long you've been using it.

@rafaelgomesxyz rafaelgomesxyz changed the title Fix a bug that changing 'Show page divisors' option doesn't save on Chrome/Opera Fix a bug that does not persist some settings May 15, 2018
@rafaelgomesxyz rafaelgomesxyz added this to the 7.18.4 milestone May 15, 2018
@rafaelgomesxyz
Copy link
Owner

Should be fixed, it was not related to the browser.

@Tristar7
Copy link
Author

Out of interest how did that only affect some settings?

@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented May 16, 2018

You can check the commit above, it's related to the function ESGST.getOldValues.

It's the settings that were migrated when includes/excludes were implemented. They were being overwritten every time instead of only the first time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants