Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that does not filter discussions on page load if Comment Tracker is disabled #76

Closed
gizellos opened this issue Oct 29, 2017 · 16 comments
Labels

Comments

@gizellos
Copy link

I have a Discussion filter preset that hides visited discussions. If I go to the discussion list while the preset is enabled, it doesn't work. I have to disable it and then enable and it will hide them. After I reload the page, it is bugged again, though.

@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented Oct 29, 2017

Working fine for me. Script or extension? Latest version? Errors in console?

@gizellos
Copy link
Author

The extension v7.6.1. No errors in console. It is strange.

2017-10-29_162051

@gizellos
Copy link
Author

gizellos commented Oct 30, 2017

When I want to switch the preset, it won't change until I reload the page and I get this error:

esgst.js:19368 Uncaught ReferenceError: gf is not defined
at applyDfPreset (esgst.js:19368)

Maybe it is related to the issue?

@rafaelgomesxyz
Copy link
Owner

Should be fixed.

@gizellos
Copy link
Author

It is not, unfortunately. :( No I just can switch the presets normally but the visited filter is still not working automatically.

@rafaelgomesxyz
Copy link
Owner

And no errors in the console?

@gizellos
Copy link
Author

gizellos commented Nov 2, 2017

Yes, no errors. :(

I made you a gif. (Your thread is visible there because it is in exceptions.)

discussions

@rafaelgomesxyz
Copy link
Owner

I cannot reproduce this at all. Do you remember at what version it stopped working?

@gizellos
Copy link
Author

gizellos commented Nov 2, 2017

Unfortunately, I don't. Would you help you if I sent you my exported data?

@rafaelgomesxyz
Copy link
Owner

I don't think so.

@gizellos
Copy link
Author

I found out that if I scroll to another page, it will apply the filters too. Please open this issue. I hate this problem. :(

@rafaelgomesxyz
Copy link
Owner

I think I will have to need your help debugging this some other time, as I was never able to reproduce it.

@gizellos
Copy link
Author

Yes, sure thing.

@rafaelgomesxyz
Copy link
Owner

Ah, bingo, it happens for users that have Comment Tracker disabled.

@rafaelgomesxyz rafaelgomesxyz changed the title Discussion filters stopped to be applied automatically Fix a bug that does not filter discussions on page load if Comment Tracker is disabled Nov 15, 2017
@rafaelgomesxyz rafaelgomesxyz added this to the 7.7.5 milestone Nov 15, 2017
@gizellos
Copy link
Author

Aha, that's very possible because I really have it disabled. Good work!

@gizellos
Copy link
Author

Works well in the latest dev version. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants