Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reposition open popups every second #99

Closed
rafaelgomesxyz opened this issue Nov 2, 2017 · 3 comments
Closed

Reposition open popups every second #99

rafaelgomesxyz opened this issue Nov 2, 2017 · 3 comments

Comments

@rafaelgomesxyz
Copy link
Owner

Repositioning open popups every second ensures that they are always centered, without the need to trigger the repositioning from specific parts of the code or when the user clicks on a popup.

@rafaelgomesxyz rafaelgomesxyz added this to the 7.6.4 milestone Nov 2, 2017
@marlop352
Copy link
Contributor

wouldn't this have a performance cost, possibly making it slower?

@rafaelgomesxyz
Copy link
Owner Author

I don't think it would. It simply repositions popups that are open. And I haven't experienced any slowness while using this, so I'll just release it and worst case scenario I can easily revert the changes or improve it so that it's not needed every second.

@rafaelgomesxyz
Copy link
Owner Author

#101

rafaelgomesxyz pushed a commit that referenced this issue Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants