Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Editors #55

Closed
kas84 opened this issue Sep 30, 2020 · 11 comments
Closed

Custom Editors #55

kas84 opened this issue Sep 30, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@kas84
Copy link

kas84 commented Sep 30, 2020

Do you have any examples on setting up a datepicker or any other custom component as a cell editor?

@revolist
Copy link
Owner

@kas84 not yet, we have a way to apply any 3rd party editor
https://revolist.github.io/revogrid/?path=/docs/docs-custom-editor--page

You can apply any 3rd party component you'd like.
We have it planned for the next release to support several types: input, datepicker, select, multiselect.

@kas84
Copy link
Author

kas84 commented Oct 3, 2020

Would be great to have a select with search functionality like the image I attach.
Would be awesome if there's an option to make it editable on one single click or at least that on type it would start searching on the select options.

1_Ag2lbKhZ5zOaJcBb1SU3jw

@revolist revolist added the enhancement New feature or request label Oct 16, 2020
@bbbford
Copy link

bbbford commented Nov 9, 2020

@kas84 not yet, we have a way to apply any 3rd party editor
https://revolist.github.io/revogrid/?path=/docs/docs-custom-editor--page

You can apply any 3rd party component you'd like.
We have it planned for the next release to support several types: input, datepicker, select, multiselect.

Looking forward to next release! Keep up the great work!

@revolist
Copy link
Owner

https://revolist.github.io/revogrid/guide/column.types.html
select, string, number added

@kas84
Copy link
Author

kas84 commented Nov 23, 2020

The columnType Number doesn't have an editor, does it? And in that case, shouldn't the input should have an input type="number", because you care about that when you edit a cell and type a "4", it's actually a number and not a string.

@mikproto
Copy link
Collaborator

mikproto commented Nov 23, 2020

@kas84 thank you for the comment.
Number type has render only specification, editor can be quite specific per project. And it'll require validators etc.
We have multiple huge projects running on revo-grid where we need to allow enter anything and parse it on our side.

Also you are always welcome to provide improved solution or even separate column number plugin I think it'll be included in main specification quite fast.

@revolist
Copy link
Owner

Date(editor), Select(renderer/editor), Number(as render) added.
Plugin system added.

Read docs for more information:
https://revolist.github.io/revogrid/guide/column.types.html

@kas84
Copy link
Author

kas84 commented Nov 25, 2020

The select type cell won't work as it is for the on Tab behaviour, like the text editor currently does. Would you be open to integrate a pull request for both revogrid-column-select and revo-dropdown?

Add to this, would you be willing to add an option to ignore accents like if you type "peloton" and there's an option named "pelotón", it won't get filtered?

On revogrid-column-select I had to add originalEvent into the types because although it was already passed, it wasn't on the types and at least vscode wouldn't allow me to check originalEvent because ObjectChange and ArrayChange didn't have it in their types.

Captura de pantalla 2020-11-25 a las 14 45 38

Captura de pantalla 2020-11-25 a las 14 46 19

@revolist
Copy link
Owner

Hey @kas84 , I’ll be happy to review your request, please send me when you can.

@kas84
Copy link
Author

kas84 commented Nov 26, 2020

Done in both projects

Thanks for this amazing component :)

@revolist
Copy link
Owner

@kas84 merged, sorry for the delay. Publishing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants