Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-instance functionality #14

Closed
TaiAurori opened this issue Jun 11, 2022 · 20 comments
Closed

Add cross-instance functionality #14

TaiAurori opened this issue Jun 11, 2022 · 20 comments
Assignees
Labels
enhancement New feature or request

Comments

@TaiAurori
Copy link
Contributor

What do you want to see?

Add a rudimentary form of switching the API path used by the app, so situations like this don't need to occur.

@TaiAurori TaiAurori added the enhancement New feature or request label Jun 11, 2022
@TaiAurori TaiAurori self-assigned this Jun 11, 2022
@Rexogamer
Copy link
Member

This is almost done - however, at the moment the custom instance URL isn't being loaded in time; still trying to figure out a solution to this

@Rexogamer
Copy link
Member

Rexogamer commented Apr 17, 2023

This has now been added; you can specify a custom instance, and once the app is reopened it will connect to it - however, it's a bit clunky (you have to reopen the app after changing the URL) and the support is pretty basic so I'm not 100% sure whether I want to enable this by default in the next version

@ggtylerr
Copy link
Contributor

Hey, thank you guys for adding it :) Not sure why this is now the only client that supports multi instance, but it's a start!

Also, why'd you guys rebase off of my fork 😅 Not mad or anything, I just think it's funny how I'm now technically a contributor (even though I basically didn't do anything)

@Rexogamer
Copy link
Member

You bumped a bunch of deps at one point and had a much more extensive README; I think at the time I wanted to save some time (as I was also unsure as to whether I was going to continue maintaining the project in a fork or here)

@ggtylerr
Copy link
Contributor

ggtylerr commented Apr 30, 2023

I don't remember changing any deps, I think I just ran yarn lol

@ggtylerr
Copy link
Contributor

ggtylerr commented May 3, 2023

It seems integration is a little buggy. Using it with Divolt results in a boot loading loop upon reloads, editing messages with a 400 (sometimes?), and whatever this is whenever you send something:
Screenshot_20230503-051416_RVMob Canary.jpg

I'm not sure where the relevant logfiles are and pressing debug just crashes the app, so here are the screenshots from warnings:
Upon reloading and attempting to log in
Screenshot_20230503-051037_RVMob Canary.jpg
Upon editing a message (maybe its just char limit? idk)
Screenshot_20230503-051241_RVMob Canary.jpg
Upon pressing "Debug"
Screenshot_20230503-051910_RVMob Canary.jpg
Screenshot_20230503-051915_RVMob Canary.jpg

@Rexogamer
Copy link
Member

I suspect it might not've logged in properly, although I'll have to do further debugging; however, last time I tried to set up a Divolt account it seemingly just kept erroring so hmm

@ggtylerr
Copy link
Contributor

ggtylerr commented May 3, 2023

...however, last time I tried to set up a Divolt account it seemingly just kept erroring so hmm

If it was a database error, it's Divolt's side. There's some bug in the DB that sometimes causes it to crash. We just have it on an hourly restart for now. (Of course, it's good to check if you're able to login on the website first)

@Rexogamer
Copy link
Member

I managed to log in without any issues on a test account so hmmm

@ggtylerr
Copy link
Contributor

ggtylerr commented May 5, 2023

I managed to log in without any issues on a test account so hmmm

Reloads work?

@Rexogamer
Copy link
Member

?

@ggtylerr
Copy link
Contributor

ggtylerr commented May 5, 2023

Does restarting the app log in properly on your end, or does it result in a promise rejection, like this: Screenshot_20230505-133037_RVMob Canary.jpg

@Rexogamer
Copy link
Member

Good catch - that issue should be fixed in bc41588. I haven't encountered any other issues though 🤔

Also, regarding your fork of RVMob, is it mostly just to change the URLs? If so, it might be worth upstreaming support for them in some way but hmm

@ggtylerr
Copy link
Contributor

ggtylerr commented May 5, 2023

Good catch - that issue should be fixed in bc41588. I haven't encountered any other issues though 🤔

Thank you. I'm getting a different error now, though. This one occurs on the login screen regardless of restarts. Tried reinstall too. Not sure why this is occuring, might try it on WSA later.
Screenshot_20230505-151050_RVMob Canary.jpg

Also, regarding your fork of RVMob, is it mostly just to change the URLs? If so, it might be worth upstreaming support for them in some way but hmm

Basically, yeah. Since RVMob now supports instance switching, we'll probably stop working on DVMob and recommend people to use this instead.
(also note - this technically isnt my fork anymore since I transferred ownership to FMHY)

@Rexogamer
Copy link
Member

That error seems to be related to certificates - I haven't seen it locally so it might be a Divolt issue but I'm not 100% sure

Basically, yeah. Since RVMob now supports instance switching, we'll probably stop working on DVMob and recommend people to use this instead.

Sounds good ^^

@MasicoreLord
Copy link

That error seems to be related to certificates - I haven't seen it locally so it might be a Divolt issue but I'm not 100% sure

Basically, yeah. Since RVMob now supports instance switching, we'll probably stop working on DVMob and recommend people to use this instead.

Sounds good ^^

Wouldn't an easy fix, be to explicitely disable any certificate pinning? Then you don't have to worry about certificate errors, as it'd then fallback to whatever the os or user ended up trusted.

@MasicoreLord
Copy link

In-case you were thinking of publishing RVMob to the play store, I even searched to see if omitting client certificate pinning would stop it from getting approved, and seems it's not a requirement, and even discouraged to be used as a solution according to this article:
https://developer.android.com/training/articles/security-ssl

@Rexogamer
Copy link
Member

RVMob doesn't pin any certificates directly so I'm not sure where this issue is coming from

@ggtylerr
Copy link
Contributor

ggtylerr commented May 5, 2023

That error seems to be related to certificates - I haven't seen it locally so it might be a Divolt issue but I'm not 100% sure

I think it was, I'm not getting it anymore, both on WSA and on my Note 10. Maybe the spaghetti code somehow fixed itself or the hourly restart fixed it, idk...

Subsequent restarts do work, though, so at least that's fixed :D

@revoltchat revoltchat deleted a comment from MasicoreLord May 5, 2023
@Rexogamer
Copy link
Member

I'm gonna close this issue as completed. The final polishing work will be listed in another issue; if you encounter any issues, either open another issue or let me know in the RVMob server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants