Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependancy missing #172

Closed
dyve opened this issue Jan 20, 2018 · 2 comments
Closed

Dependancy missing #172

dyve opened this issue Jan 20, 2018 · 2 comments

Comments

@dyve
Copy link
Contributor

dyve commented Jan 20, 2018

Python 2.7, Django 1.11 and django-health-check 3.3.0 crash on a missing dependency:

File "/Users/dylan/.pyenv/versions/meetnetten/lib/python2.7/site-packages/health_check/views.py", line 2, in <module>
    from concurrent.futures import ThreadPoolExecutor
ImportError: No module named concurrent.futures

Reverting to 2.4.0 resolves this error for now.

@dyve
Copy link
Contributor Author

dyve commented Jan 20, 2018

Tox only runs Python 3, which does not have this issue.

I'd suggest following Django support policy, and support Python 2.7 + Django 1.11 during LTS period.

I can do a PR with an altered tox setup. Easiest solution for Python 2.7 would be to document that futures needs to be added to requirements.txt manually?

@dyve
Copy link
Contributor Author

dyve commented Jan 20, 2018

Upon cloning the repo I discovered the ChangeLog (somehow not visible on GitHub for me, will investigate). Dropping Python 2 is clearly documented, so this issue can be closed.

@dyve dyve closed this as completed Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant