Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Drop Django <1.8 support #63

Merged
merged 10 commits into from Oct 18, 2017
Merged

Conversation

jefftriplett
Copy link
Member

In theory, nothing has changed which will prevent older versions from working internally. However, we want to set a reasonable standard for which versions to update for yet keep our testsuite running quickly.

Fixes #62

Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-4.0%) to 93.141% when pulling 17520a1 on drop-django-pre-1-8-support into cd4500d on master.

Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-3.3%) to 93.796% when pulling 6d83a1f on drop-django-pre-1-8-support into cd4500d on master.

2 similar comments
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-3.3%) to 93.796% when pulling 6d83a1f on drop-django-pre-1-8-support into cd4500d on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.3%) to 93.796% when pulling 6d83a1f on drop-django-pre-1-8-support into cd4500d on master.

.travis.yml Outdated
@@ -15,8 +15,6 @@ script:
after_success:
- coveralls
env:
- DJANGO="Django<1.6"
- DJANGO="Django<1.7"
- DJANGO="Django<1.8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves to Django1.7 and can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-3.4%) to 93.727% when pulling 9086e3c on drop-django-pre-1-8-support into cd4500d on master.

@fcurella
Copy link
Collaborator

could you also remove the checks for python < 1.6? https://github.com/revsys/django-test-plus/blob/master/test_plus/test.py#L25

@jefftriplett jefftriplett changed the title Drop Django <1.8 support WIP: Drop Django <1.8 support Oct 18, 2017
Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
Signed-off-by: Jeff Triplett <jeff.triplett@gmail.com>
@coveralls
Copy link

coveralls commented Oct 18, 2017

Coverage Status

Coverage decreased (-0.2%) to 96.899% when pulling aa85b1c on drop-django-pre-1-8-support into cd4500d on master.

@jefftriplett jefftriplett changed the title WIP: Drop Django <1.8 support 🔥 Drop Django <1.8 support Oct 18, 2017
@jefftriplett jefftriplett merged commit 3f1f2b7 into master Oct 18, 2017
@jefftriplett jefftriplett deleted the drop-django-pre-1-8-support branch October 18, 2017 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants