Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organization recognition search only searches the start of name #127

Closed
dryice opened this issue Apr 4, 2023 · 4 comments · Fixed by #134
Closed

organization recognition search only searches the start of name #127

dryice opened this issue Apr 4, 2023 · 4 comments · Fixed by #134
Assignees

Comments

@dryice
Copy link
Collaborator

dryice commented Apr 4, 2023

code is here

The issue is for name like "WOO HUI LIN (HU HUILIN" (user ID 1036612 on Cerra SG), searching "woo" works, but searching "Hui" doesn't. @bryan got a report from McDonalds.

Not sure if that's a requirements from other clients or we can change.

@suryaiiit
Copy link
Collaborator

suryaiiit commented Apr 4, 2023

I think the issue is because we are filtering the user name by starts with at code instead of contains

woo works as it is the first few characters, but hui is in the middle of the name

@yatishTrootech yatishTrootech linked a pull request Apr 6, 2023 that will close this issue
@Biplabsing
Copy link

Biplabsing commented Apr 11, 2023

@yatishTrootech @VipinRewardz as we discussed we have some issue From FE side ,so yustar is working on it .it will be Better that if we clear this from FE side first then close this card.
Note - BE side from Api response its working fine
PFA

CC @suryaiiit @SteffiVinod5

@suryaiiit
Copy link
Collaborator

@Biplabsing the issue is with the API response, if the API response is fine then we can close this.

@Biplabsing
Copy link

Working fine on skordev
@suryaiiit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants