Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback] User Unable to access comments and post detail #129

Closed
yatishTrootech opened this issue Apr 4, 2023 · 1 comment · Fixed by #131
Closed

[Feedback] User Unable to access comments and post detail #129

yatishTrootech opened this issue Apr 4, 2023 · 1 comment · Fixed by #131
Assignees

Comments

@yatishTrootech
Copy link
Contributor

yatishTrootech commented Apr 4, 2023

User: melissa_joy_ho@nuhs.edu.sg

Image

User unable to access comments

One more Issue: https://cerrapoints.com/admin/app_usage/logmodel/113333914/?_changelist_filters=q%3Dmelissa_joy_ho%2540nuhs.edu.sg

@yatishTrootech yatishTrootech self-assigned this Apr 4, 2023
@yatishTrootech yatishTrootech changed the title User Unable to access comments User Unable to access comments and post detail Apr 4, 2023
@suryaiiit suryaiiit changed the title User Unable to access comments and post detail [Feedback] User Unable to access comments and post detail Apr 5, 2023
@yatishTrootech
Copy link
Contributor Author

Checked in Previous version date (oct-11-2022)

We were using queryset for getting posts

result = accessible_posts_by_user(user, org, allow_feedback=allow_feedback)
(No admin user is allowed to access posts)

We were not allowing admin to comment on the post
Here accessible posts are

accessible_posts = accessible_posts_by_user(

before comment

Then after we made a change related allow admin user to access comment for feedback_post
Here

self.user_allowed_to_comment(accessible_posts_queryset=accessible_posts_queryset)

But before that we have a condition

if post_id not in accessible_posts:

Which will restrict admin user to comment (Here also we hjave to allow admin for feedback post comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant