Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use prototype.__proto__ #37

Closed
crocket opened this issue Jun 20, 2014 · 5 comments
Closed

Don't use prototype.__proto__ #37

crocket opened this issue Jun 20, 2014 · 5 comments

Comments

@crocket
Copy link

crocket commented Jun 20, 2014

In lib/stringify/identity.js, I see Compiler.prototype.__proto__ = Base.prototype;

It could cause problems later since __proto__ is not standard.

I recommend using Compiler.prototype = new Base();

@tj
Copy link
Member

tj commented Jun 20, 2014

really doesn't matter it's not going anywhere

@tj tj closed this as completed Jun 20, 2014
@crocket
Copy link
Author

crocket commented Jun 20, 2014

I'm using it via browserify.
On internet explorer, identify.js fails to stringify css because mapVisit belongs to __proto__ and IE fails to access mapVisit via this.mapVisit

The fix is Compiler.prototype = new Base(); in identify.js

Can you please do something about this?

@tj
Copy link
Member

tj commented Jun 20, 2014

ah fair enough, in that case we should use the silly util.inherit thing

@necolas
Copy link
Contributor

necolas commented Jun 20, 2014

we don't support browsers anymore. most plugin developers don't either, so you shouldn't rely on it.

@tj
Copy link
Member

tj commented Jun 20, 2014

^ the problem with browserify, never know whatcha gonna get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants