Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend don't work with media queries. #95

Closed
simme opened this issue Jun 7, 2013 · 5 comments
Closed

Extend don't work with media queries. #95

simme opened this issue Jun 7, 2013 · 5 comments

Comments

@simme
Copy link
Contributor

simme commented Jun 7, 2013

The current implementation of extend works by adding the extending selector to the selector list for the extension block. However, if extending inside a media query, that selector is moved out from the media query block.

Would the best fix to add the properties to the extending selector instead? At least when inside a media query.

@jonathanong
Copy link
Contributor

not sure he wants to support that: #52 (comment)

you can use my "extend" plugin that i haven't run into any issues with yet: https://github.com/jonathanong/rework-inherit would love to hear feedback

@tj
Copy link
Member

tj commented Jun 7, 2013

hmm not sure why I was against the media stuff now that I look at it again, looks fine to me haha. If we add a component.json to rework-inherit so we can still build rework / styl standalone scripts etc I'd be happy to move over to that

@jonathanong
Copy link
Contributor

it already has a component.json. i'm already using it as a standalone script. i'll remove the disable media query option since it's pretty pointless.

@tj
Copy link
Member

tj commented Jun 11, 2013

ohh ok cool sounds good

@jonathanong
Copy link
Contributor

okay, so i removed the media inheritance option and i allowed it to use extend as well as inherit as a property by default, so just adding it as a dep shouldn't require any fiddling.

@tj tj closed this as completed Jun 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants