New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend don't work with media queries. #95
Comments
not sure he wants to support that: #52 (comment) you can use my "extend" plugin that i haven't run into any issues with yet: https://github.com/jonathanong/rework-inherit would love to hear feedback |
hmm not sure why I was against the media stuff now that I look at it again, looks fine to me haha. If we add a component.json to rework-inherit so we can still build rework / styl standalone scripts etc I'd be happy to move over to that |
it already has a component.json. i'm already using it as a standalone script. i'll remove the disable media query option since it's pretty pointless. |
ohh ok cool sounds good |
okay, so i removed the media inheritance option and i allowed it to use |
The current implementation of extend works by adding the extending selector to the selector list for the extension block. However, if extending inside a media query, that selector is moved out from the media query block.
Would the best fix to add the properties to the extending selector instead? At least when inside a media query.
The text was updated successfully, but these errors were encountered: