Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation warnings #25

Closed
anders9ustafsson opened this issue Feb 10, 2015 · 2 comments
Closed

Compilation warnings #25

anders9ustafsson opened this issue Feb 10, 2015 · 2 comments

Comments

@anders9ustafsson
Copy link
Contributor

Rex,

just wanted to highlight some compilation warnings that I experience with the latest source code. regarding the new Tag class. If I am not mistaken, you may run into performance issues with collections if GetHashCode is not overridden while Equals is.

Here is the warning log:

1>C:\Users\Anders\Documents\Visual Studio 2012\Projects\Evil-DICOM\EvilDICOM.Core\EvilDICOM.Core\Element\Tag.cs(13,18,13,21): warning CS0659: 'EvilDICOM.Core.Element.Tag' overrides Object.Equals(object o) but does not override Object.GetHashCode()
1>C:\Users\Anders\Documents\Visual Studio 2012\Projects\Evil-DICOM\EvilDICOM.Core\EvilDICOM.Core\Element\Tag.cs(13,18,13,21): warning CS0661: 'EvilDICOM.Core.Element.Tag' defines operator == or operator != but does not override Object.GetHashCode()

Best regards,
Anders

@anders9ustafsson
Copy link
Contributor Author

I have added a fix for this issue in my pull request #26.

@rexcardan
Copy link
Owner

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants