Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve swagger-ui integration #19

Closed
3 tasks done
artemklevtsov opened this issue Aug 18, 2018 · 3 comments
Closed
3 tasks done

Improve swagger-ui integration #19

artemklevtsov opened this issue Aug 18, 2018 · 3 comments
Milestone
0.2.0

Comments

@artemklevtsov
Copy link
Collaborator

artemklevtsov commented Aug 18, 2018 •
edited by dselivanov

swagger package contains obsolete swagger-ui version.

  • - move swagger files to RestRserve and remove swagger dependency
  • - refactor write_swagger_ui_index_html: move index_html to file in inst/
  • - refactor RestRserveApplication$add_swagger_ui to use internal swagger files
@dselivanov
Copy link
Collaborator

I don't think this is good idea to bundle all the swagger assets to RestRserve - this static files are quite heavy and I'm not sure we want to have them under version control. It may be better to send PR to https://github.com/rstudio/swagger and ask for update (I did it last time in December - rstudio/swagger#3).

@artemklevtsov
Copy link
Collaborator Author

Another way to download swagger-iu from the git-repo when use add_swagger_ui.

@artemklevtsov artemklevtsov mentioned this issue Jul 21, 2019
Merged
@dselivanov dselivanov added this to the 0.2 milestone Jul 29, 2019
@artemklevtsov
Copy link
Collaborator Author

Closed by #35.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
2 participants
@artemklevtsov @dselivanov