Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When downloading results from EUCTR, sometimes fails due to error with invalid argument #28

Closed
zhengzheli opened this issue Oct 11, 2023 · 2 comments

Comments

@zhengzheli
Copy link

zhengzheli commented Oct 11, 2023

if (any(!saved)) {
                warning("Could not save ", nonXmlFiles[!saved],
                        call. = FALSE, immediate. = TRUE)
              }

the variable saved is an invalid argument. After commenting out this clause it worked.

@rfhb
Copy link
Owner

rfhb commented Oct 11, 2023

  • Thanks for indicating an issue, please provide an example that triggers the issue
  • As the issue seems to be related to long path names, it is dependent on the operating system and the value of parameter documents.path in ctrLoadQueryIntoDb; a short(er) documents.path is recommended
  • Thanks for PR fixErrorWithSavedBeingAnInvalidArgument #27, but it is not an option to delete code that informs users
  • A code line was missing and has now been added, see https://github.com/rfhb/ctrdata/blob/master/R/main.R#L1725
  • Please try 3894c56 with devtools::install_github("rfhb/ctrdata") and update this issue, thanks

@zhengzheli
Copy link
Author

@rfhb , thank you for your work on this library, and I can confirm this fixed the issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants