Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: set values below a threshold as NA #135

Open
cvanderaa opened this issue Jun 16, 2021 · 1 comment
Open

feature request: set values below a threshold as NA #135

cvanderaa opened this issue Jun 16, 2021 · 1 comment

Comments

@cvanderaa
Copy link
Collaborator

The normalization function in SCeptre (from Schoof et al. 2021 paper) performs at some moment an NA thresholding, that is quantitative values below a given threshold are set as NA. I personally think this should not be performed in a normalization function, but it could be implemented in a separate function. This would be very similar to zeroIsNA but it must require an additional argument that provides the threshold below which the data is considered missing.

Do you think this functionality is worth being included in QFeatures? Or do we already have this but I missed it?

@lgatto
Copy link
Member

lgatto commented Jun 17, 2021

I don't think we should change zeroIsNA(x) to zeroIsNA(x, ..., threshold = 0), but we could have a function setToZero(x, min) that sets values <= min to 0. Or could you not simply create that function and apply it on the fly (as a example of how to process assays with user-provided functions) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants