Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink assays nomenclature #194

Closed
cvanderaa opened this issue Sep 12, 2023 · 5 comments
Closed

Rethink assays nomenclature #194

cvanderaa opened this issue Sep 12, 2023 · 5 comments

Comments

@cvanderaa
Copy link
Collaborator

cvanderaa commented Sep 12, 2023

As discussed for the protocol paper with @samgregoire, the fact that the quantitative data in a SummarizedExperiment and the data objects in a QFeatures are both called assays complicates the description of the data structure.

I would suggest renaming the QFeatures' assays.

  • sets: it is generic, like data sets (and in honor of the previously supported ExpressionSet class)
  • experiments: because each object is a [SingleCell|Summarized]Experiment. Actually, the objects in QFeatures are retrieved using experiments(qf).
  • elements: because each object is in fact an element of a list (ExperimentList)
  • other?
@cvanderaa cvanderaa changed the title Rethink assay nomenclature Rethink assays nomenclature Sep 12, 2023
@lmsimp
Copy link

lmsimp commented Sep 12, 2023

Following @cvanderaa 😀 as you know we use QFeatures extensively in our lab and we have thought the same 👍

CCing @Charl-Hutchings @csdaw

@lgatto
Copy link
Member

lgatto commented Dec 12, 2023

Could you share your thoughts on this. In our latest paper, we refer to the elements of a QFeatures object as sets. (@samgregoire, could you confirm).

@samgregoire
Copy link

I confirm.

  • We use assay or quantitative assay to refer to SummarizedExperiment's quantitative data (since they are extracted using the assay() function).
  • We use sets to refer to data objects in a QFeatures.

@lmsimp
Copy link

lmsimp commented Dec 13, 2023

This great 👍 I think sets works well but any of Chris' suggestions above would be preferable over assays.

@tavareshugo
Copy link

my vote for "experiments" based on discussions on #197

@lgatto lgatto closed this as completed Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants