Use local variables to improve maintainability/documentation

[dehesselle]

Although it is perfectly fine to use parameters as $1and $2 in the code like here...

syno_autoshutdown/autoshutdown.sh

Lines 309 to 319 in 66d9a30

	notification()
	{
	# $1: system (myname)
	# $2: message
	if [ "x$IFTTT_KEY" != "x" ]; then
	if [ "x$IFTTT_EVENT" != "x" ]; then
	if [ "x$1" != "x" ]; then
	MY_NAME=$1
	MY_STATUS=$2
	writelog "D" "$MY_NAME"
	writelog "D" "$MY_STATUS"

... I suggest to always assign those to local variables as first thing in every function. This is a measure to make the code speak more for itself (instead having comments do that - have comments explain the non-trivial stuff).

Example

 notification() 
 { 
 	local system=$1    # myname
        local message=$2
 
 	if [ "x$IFTTT_KEY" != "x" ]; then 
 		if [ "x$IFTTT_EVENT" != "x" ]; then 
 			if [ "x$system" != "x" ]; then 
 				MY_NAME=$system 
 				MY_STATUS=$message
 				writelog "D" "$MY_NAME" 
 				writelog "D" "$MY_STATUS" 

[rfuehrer]

I have already corrected this in prominent places and it has to be tested. At this point we should also consider how local/global/... variables should be written at all.