Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore subdomains on reddit URLs #16426

Closed
5 of 9 tasks
llyyr opened this issue May 10, 2018 · 0 comments · Fixed by #16427
Closed
5 of 9 tasks

Ignore subdomains on reddit URLs #16426

llyyr opened this issue May 10, 2018 · 0 comments · Fixed by #16427
Labels

Comments

@llyyr
Copy link
Contributor

llyyr commented May 10, 2018

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.05.09. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2018.05.09

Before submitting an issue make sure you have:

  • At least skimmed through the README, most notably the FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.


Description of your issue, suggested solution and other information

Various subs use dm or nm subdomain which apply different css, there's also np subdomain which does the same. reddit also has a massive number of 2 alphabet subdomains to serve the site in different languages.

youtube-dl already supports www and old, but it's not possible to add support for each and every one of them so it'd be better to ignore it altogether since it doesn't affect reddit detection or .json API availability.

I'll submit a PR if this solution is acceptable.

@llyyr llyyr changed the title Ignore subdomains on reddit.com URLs Ignore subdomains on redditURLs May 10, 2018
@llyyr llyyr changed the title Ignore subdomains on redditURLs Ignore subdomains on reddit URLs May 10, 2018
@llyyr llyyr mentioned this issue May 10, 2018
9 tasks
@dstftw dstftw added the fixed label May 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants