Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbc] Support new domain name (closes #20251) #20359

Merged
merged 2 commits into from Mar 17, 2019
Merged

[cbc] Support new domain name (closes #20251) #20359

merged 2 commits into from Mar 17, 2019

Conversation

tylerszabo
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Per Issue #20251 CBC altered their web player to use a different domain. The new domain behaves like the old domain with respect to youtube-dl so only the regex needs to be updated (and a test case added).

@tylerszabo
Copy link
Contributor Author

Weird, that issue existed a minute ago.

@dstftw dstftw merged commit 81dada0 into ytdl-org:master Mar 17, 2019
@tylerszabo tylerszabo deleted the cbc branch May 27, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants