Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpankBang] Add new extractor #5365

Merged
merged 4 commits into from Apr 6, 2015
Merged

Conversation

newtonelectron
Copy link
Contributor

Add an extractor for spankbang.com.

"""Extractor for http://spankbang.com"""

_VALID_URL = r"https?://(?:www\.)?spankbang\.com/(?P<id>\w+)/video/.*"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, sorry.
I think the stream_key is dynamic. I'm not sure how to test for that or if it would be worth it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add a test video as described in developer instructions or take a look at any other extractor.

@dstftw dstftw merged commit c7ac5dc into ytdl-org:master Apr 6, 2015
@dstftw
Copy link
Collaborator

dstftw commented Apr 6, 2015

Thanks, merged.
Do you want to be credited as one of the authors of youtube-dl? If so under what name?

@newtonelectron newtonelectron deleted the spankbang.com branch May 17, 2015 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants