-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube-dl: myvideo, rtmp support #842
Conversation
This is really cool, but I fear that we will have to ask @dersphere (ping) to kindly allow releasing your rewrite in Public Domain to include it. |
Hi, of course you can use the code. You are also allowed to change its license to any other open source license you need. Great project btw :) |
Thanks! (I love the open source community!) However, I have to ask it explicitly, as PD might not be considered a open source licence... Do you allow us to release this code in Public Domain, according to the |
y = (y + box[x]) % 256 | ||
box[x], box[y] = box[y], box[x] | ||
# out.append(chr(ord(char) ^ box[(box[x] + box[y]) % 256])) | ||
out.append(chr(char ^ box[(box[x] + box[y]) % 256])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
youtube-dl runs on both Python 2 and 3, so probably the commented line is better, but I'll review and fix it merging
Yes, you are allowed to do that. |
Perfect, merging it with some corrections. However, rtmpdump stops at 98.7%, and triggers a retry, I wonder if it does that for all videos and we can ignore it... |
@dersphere code, from dersphere/plugin.video.myvideo_de.git rewritten by @mc2avr released in the Public Domain by the author ref: #842
Done, thanks a lot to both! 🎆 I'll have a look at that rtmpdump early finish thing later. |
Hello,
i have rewrite the MyVideoIE from an XBMC plugin. I hope the license is ok.
Original Code from: https://github.com/dersphere/plugin.video.myvideo_de.git (scraper.py)
Copyright (C) 2013 Tristan Fischer (sphere@dersphere.de) - GPLv3/GPLv2 ?
This is a fix for #247
my test enviroment:
Python 3.3.1
RTMPDump v2.4 (last git, with DEBUG flag)
successful tested videos:
http://www.myvideo.de/watch/8229274/bowling_fail_or_win
http://www.myvideo.de/watch/8418541/Deichkind_Leider_geil
http://www.myvideo.de/watch/8328930/Nickelback_When_We_Stand_Together_Official_Video
http://www.myvideo.de/watch/8357965/Maria_Mena_Homeless
http://www.myvideo.de/watch/9049079/Kosheen_Catch
http://www.myvideo.de/watch/9104080/Avril_Lavigne_Here_s_To_Never_Growing_Up