Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: myvideo, rtmp support #842

Merged
merged 1 commit into from
May 20, 2013
Merged

Conversation

mc2avr
Copy link
Contributor

@mc2avr mc2avr commented May 15, 2013

@FiloSottile
Copy link
Collaborator

This is really cool, but I fear that we will have to ask @dersphere (ping) to kindly allow releasing your rewrite in Public Domain to include it.

@dersphere
Copy link

Hi,

of course you can use the code. You are also allowed to change its license to any other open source license you need.

Great project btw :)

@FiloSottile
Copy link
Collaborator

Thanks! (I love the open source community!)

However, I have to ask it explicitly, as PD might not be considered a open source licence...

Do you allow us to release this code in Public Domain, according to the LICENSE file? This mean renouncing on any right over it and that it can be used by anyone anyhow. (Thanks!)

y = (y + box[x]) % 256
box[x], box[y] = box[y], box[x]
# out.append(chr(ord(char) ^ box[(box[x] + box[y]) % 256]))
out.append(chr(char ^ box[(box[x] + box[y]) % 256]))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youtube-dl runs on both Python 2 and 3, so probably the commented line is better, but I'll review and fix it merging

@dersphere
Copy link

Yes, you are allowed to do that.

@FiloSottile
Copy link
Collaborator

Perfect, merging it with some corrections.

However, rtmpdump stops at 98.7%, and triggers a retry, I wonder if it does that for all videos and we can ignore it...

@ghost ghost assigned FiloSottile May 20, 2013
FiloSottile added a commit that referenced this pull request May 20, 2013
@dersphere code, from dersphere/plugin.video.myvideo_de.git
rewritten by @mc2avr
released in the Public Domain by the author
ref: #842
@FiloSottile FiloSottile merged commit de5d66d into ytdl-org:master May 20, 2013
@FiloSottile
Copy link
Collaborator

Done, thanks a lot to both! 🎆

I'll have a look at that rtmpdump early finish thing later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants