New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extractor for trailers on Comingsoon.it #9890
Conversation
'format': 'Standard Definition' | ||
}, | ||
{ | ||
'url': 'http://video.comingsoon.it/MP4/' + video_id + '.mp4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Download URLs for both formats are equal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
'format_id': 'sd' | ||
}, | ||
{ | ||
'url': 'http://video.comingsoon.it/MP4/' + video_id + 'HD.mp4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not all video has HD quality and even some of them doesn't have the same url format so it better to follow the logic in the browser:
downloading the embed page which contain video urls: http://www.comingsoon.it/videoplayer/embed/?idv=<id>
extract vLwRes
and vHiRes
, if both urls are the same then only sd quality is available else both sd and hd format is available.
also don't hardcode ext
it can be detected automaticaly from the url(some video in the web site served as flv files).
… without and HD format
@MaurizioPz is the extractor working for comingsoon? |
No description provided.