Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extractor for trailers on Comingsoon.it #9890

Closed
wants to merge 4 commits into from

Conversation

MaurizioPz
Copy link

No description provided.

'format': 'Standard Definition'
},
{
'url': 'http://video.comingsoon.it/MP4/' + video_id + '.mp4',
Copy link
Collaborator

@dstftw dstftw Jun 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download URLs for both formats are equal.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

'format_id': 'sd'
},
{
'url': 'http://video.comingsoon.it/MP4/' + video_id + 'HD.mp4',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not all video has HD quality and even some of them doesn't have the same url format so it better to follow the logic in the browser:
downloading the embed page which contain video urls: http://www.comingsoon.it/videoplayer/embed/?idv=<id>
extract vLwRes and vHiRes, if both urls are the same then only sd quality is available else both sd and hd format is available.
also don't hardcode ext it can be detected automaticaly from the url(some video in the web site served as flv files).

@jasan-s
Copy link

jasan-s commented Aug 22, 2017

@MaurizioPz is the extractor working for comingsoon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defunct PR source branch is not accessible pending-fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants