New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some failing examples (comparison between Win/Mac/Linux) #156
Comments
Yikes, I should've checked examples before submitting my changes 😬 . It is easy to fix, give me a sec. |
Should be fixed in bf030a0 |
Yeah, I assumed it was an easy fix for someone familiar with the code base. But I also wanted to just go through the examples and see the differences (mostly between Win/Lin, of course)... |
Some stats for build times with just these small fixes (so just linking really). Just for those wondering how these machines would perform against each other with rust/llvm:
After the fixes (same format: 'debug - release'):
|
@romancerny That's probably because the "primary_monitor()" call for a winit window is not available on Wayland. "current_monitor()" is not marked as "does not work on Wayland", but it still returns None for me. The only way to get a monitor for me on Wayland is through the "available_monitors()" call. Then the dropdown is populated, but the next issue is that Wayland doesn't support exclusive fullscreen so it's not actually doing anything. The dropdown handler would only resize the backbuffer and make everything worse. For usability reasons, the UI demo and rusty-shooter could be changed to hide the dropdown when no video modes can be found because of missing functionality in winit and/or Wayland. |
That makes sense. Thanks for the reply. |
Closing this due to large period of inactivity. Feel free to reopen if needed. |
Hello @mrDIMAS,
I just thought I would run the examples with the new light intensity code here on Win/Mac/Linux (I am not sure if all tests worked before light intensity...just got curious as I found some "Intensity" errors on some examples).
Take with a grain of salt, of course (I didn't run the examples for very long each time and I might not have waited long enough for some tests to load in debug mode? Maybe?)
Machine specs and results (rustc 1.54.0):
Specs:
Examples (debug FPS - then release...or error message):
The text was updated successfully, but these errors were encountered: