Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't support libgit2 > v0.25 #5

Closed
oblitum opened this issue Sep 13, 2017 · 2 comments
Closed

Doesn't support libgit2 > v0.25 #5

oblitum opened this issue Sep 13, 2017 · 2 comments

Comments

@oblitum
Copy link

oblitum commented Sep 13, 2017

I'm on libgit2 0.26, it doesn't build with:

~ ❯❯❯ go install github.com/rgburke/grv/cmd/grv
# gopkg.in/libgit2/git2go.v25
.go/src/gopkg.in/libgit2/git2go.v25/git.go:8:3: error: #error "Invalid libgit2 version; this git2go supports libgit2 v0.25"
 # error "Invalid libgit2 version; this git2go supports libgit2 v0.25"
   ^~~~~

So the README doesn't follow. I'm using the alternative install mechanism.

@rgburke
Copy link
Owner

rgburke commented Sep 13, 2017

Yes, the README was incorrect and I've updated it to clarify that only libgit2 0.25 is supported. In future I would like GRV not to be tied to a specific libgit2 version and for it to be dynamic/configurable. Many thanks for pointing this out!

@rgburke rgburke closed this as completed Sep 13, 2017
@oblitum
Copy link
Author

oblitum commented Sep 15, 2017

This project is great, really thank you for it.

@mckellyln mckellyln mentioned this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants