Ignite changes

[Olorun]

"With the advent of the P5 Patch it appears that the Blue Post from 7/24/20 has taken effect and Ignite is now behaving as it did in Vanilla.
This means simply that a crit is required between every tick of ignite after the first tick [..]."

Before this change, each crit reset the duration to the full 4 seconds.

However, after the changes crits need to happen after every tick of the first window, so crits need to happen in the windows of 2-4 seconds, 4-6 seconds, 6-8 seconds, 8-10 seconds, 10-12 seconds and so on.

Hope this helps you with reworking the library to properly track the duration of Ignite again.

[d87]

Jesus, damn mages

Soo... first crit between ticks extends ignite by 2s?

[d87]

Test this https://github.com/rgd87/LibClassicDurations/archive/Ignite2.zip

[Olorun]

https://www.youtube.com/watch?v=_PKJsTrzHlw&

This video explains the mechanics correctly. (in the first 3-4 minutes). And yeah, damn mages indeed.

[d87]

Well, it is I thought. And it should be working now in Ignite2 branch (released a small bugfix to ignite removal couple of minutes ago, in case you already downloaded)

[Olorun]

I'll download and test it once AQ is out, thanks for the quick help!

[Olorun]

I get the following LUA error in raids:

110x ...eakAuras\Libs\LibClassicDurations-63\classAbilities.lua:126: attempt to index local 'spellTable' (a nil value)
...eakAuras\Libs\LibClassicDurations-63\classAbilities.lua:126: in function `customAction'
...eWeakAuras\Libs\LibClassicDurations-63\core.lua:541: in function <...eWeakAuras\Libs\LibClassicDurations\core.lua:512>
...eWeakAuras\Libs\LibClassicDurations-63\core.lua:594: in function <...eWeakAuras\Libs\LibClassicDurations\core.lua:588>
(tail call): ?
(tail call): ?

Locals:
InCombatSkipped

[d87]

Fixed, try again, same link

[Olorun]

No bugs so far, seems good

[d87]

And everything is correct with Ignite?

[Olorun]

I will go through my VOD later, but I think there were still some times when it looked like the debuff timer is off. I'll let you know

[Olorun]

Just went through the VOD and there were definitely times when the debuff timer showed ~1 second but the debuff fell off (and not due to other debuffs pushing it off). Happened at least twice during AQ20 today as well.

I also got the following LUA error today:
12x ...eWeakAuras\Libs\LibClassicDurations-63\core.lua:575: attempt to index local 'spellTable' (a nil value)
...eWeakAuras\Libs\LibClassicDurations-63\core.lua:575: in function `IngiteHandler'
...eWeakAuras\Libs\LibClassicDurations-63\core.lua:597: in function <...eWeakAuras\Libs\LibClassicDurations\core.lua:588>
(tail call): ?
(tail call): ?

Locals:
InCombatSkipped

[d87]

Fixed the error. But i probably can't do anything about the inaccuracy without seeing it myself. And even then who knows what drift or delays happen while ignite is on.

[Olorun]

Alright, I'll try to find specific VOD timings and ask other mages to help me with that too

[d87]

https://github.com/rgd87/LibClassicDurations/releases
Get 1.64 from here and then you can do /script LibStub("LibClassicDurations").DEBUG_IGNITE = true
To see messages with exact timestamps

[treetip]

Was the lua error fixed in v63, this is still happening in plater classic using v63.

Tercioo/Plater-Nameplates-Classic#5

Is there some quick hack to get rid of the errors, every mage just specced fire and it's really annoying :)

[d87]

It wasn't fixed in 63, install 64

[Olorun]

I've been testing the duration in AQ20 and several mobs outside. The ignite debuff fell off several times when the library still should a duration of ~1-2 seconds, so there's definitely still something off. To reiterate, the Ignite duration is effectively 2 seconds after the first 4 seconds.