Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs: DWD weatherfaxInternetRetrieval_Europe.xml #122

Closed
rgleason opened this issue Jun 7, 2022 · 18 comments
Closed

Bugs: DWD weatherfaxInternetRetrieval_Europe.xml #122

rgleason opened this issue Jun 7, 2022 · 18 comments

Comments

@rgleason
Copy link
Owner

rgleason commented Jun 7, 2022

@ozolli

There seems to be a problem with the 500mb DWD > Europe files.
They download but do not overlay.

Attached are recently updated files to fix the weatherfaxSchedule.xml issue regarding duration.
Clean up and trim white spaces.
Try and fix some issues with downloading DWD files that users noticed.
The data files are attached.
data.zip

@ozolli How do I get access to the DWD files, when I put in a url it shows forbidden, should I be using an FTP client? I wanted to check to see the actuall 500mb files.

@rgleason
Copy link
Owner Author

rgleason commented Jun 7, 2022

Having difficulty using Filezilla I guess it does not accept ftp
When I use https the charts show up.
https://www.dwd.de/DWD/wetter/wv_spez/hobbymet/wetterkarten/ico_500ht_na_ana.png
and https://www.dwd.de/DWD/wetter/wv_spez/hobbymet/wetterkarten/ico_500ht_na_024.png
and https://www.dwd.de/DWD/wetter/wv_spez/hobbymet/wetterkarten/ico_500ht_na_048.png
etc.

And they download ok I find these files in C:\ProgramData\opencpn\plugins\weatherfax
They just are not overlaying properly. The screen jumps and nothing happens.

Screenshot (457)

Is Area C possibly wrong?

@ozolli
Copy link

ozolli commented Jun 8, 2022

Ok, I'll look into it.

Edit:
I downloaded all of them and they show up properly.
Using Ubuntu x86_64 or a RPI4 8GB it works but on the RPi it's quite slow and the opencpn process uses 1.3GB of RAM.
That may be the problem on more modest computers...

Rick, can you lower the MappingMultiplier to 1 for the lines 151 to 153 in CoordinateSets.xml and try again?
They won't map correctly as the scale is reduced but it's to see if it's better ram wise.

@rgleason
Copy link
Owner Author

rgleason commented Jun 8, 2022

ozolli Thank you! I will do that. I also need to change coordinateSets, as Manfred suggested here

Please see https://www.cruisersforum.com/forums/f134/weatherfax-97533.html#post3636159

Any suggestions? I don't see "European" being used as he suggests.

@rgleason
Copy link
Owner Author

rgleason commented Jun 8, 2022

Available in CS 1.9.34.1 tarballs
https://cloudsmith.io/~opencpn/repos/weatherfax-beta/packages/?q=1.9.34.1%20tarball

Also have pushed it to plugins master catalog and Beta catalog. Have not changed the coords.

@rgleason
Copy link
Owner Author

rgleason commented Jun 8, 2022

I just tested downloading & overlay of all DWD > Europe and after download and overlay of 7 the rest download, but do not overlay yet and image wizard does not appear either.

@ozolli
Copy link

ozolli commented Jun 9, 2022

ozolli Thank you! I will do that. I also need to change coordinateSets, as Manfred suggested here

Please see https://www.cruisersforum.com/forums/f134/weatherfax-97533.html#post3636159

Any suggestions? I don't see "European" being used as he suggests.

He uses an old, non updated file.

@ozolli
Copy link

ozolli commented Jun 9, 2022

Available in CS 1.9.34.1 tarballs https://cloudsmith.io/~opencpn/repos/weatherfax-beta/packages/?q=1.9.34.1%20tarball

Also have pushed it to plugins master catalog and Beta catalog. Have not changed the coords.

Ah no ! It was just to test if it runs better with a smaller mapping size.
When you reduce the MappingMultiplier variable you get a smaller ram footprint.
But when you change the MappingMultiplier variable you also have to change other mapping variables for an accurate mapping. Here the chart is mapped over Greenland.
You should revert this commit.

@rgleason
Copy link
Owner Author

rgleason commented Jun 9, 2022

Ok. Does it run better for rpi? I see the mapping isn't right. Also in Image Wizard the images are too small to see the Lat/Long so they should be enlarged anyway.

@rgleason
Copy link
Owner Author

rgleason commented Jun 10, 2022

I've reverted and the failures have come back. Weatherfax no longer works properly. Same issues. I will push that out next.
I think for some reason, the weatherfaxes that are failing do not have access to the coordinates, so the image wizard does not do the overlay and the file is not added to the Weatherfax menu list. Now pushed to opencpn/plugins/Beta and opencpn/plugins/master catalogs.

There are still bugs.

@ozolli
Copy link

ozolli commented Jun 10, 2022

As I wrote ealier, it works fine on my PC with ubuntu and ok but slow on my RPi4.
I'm sure it's due to cpu time and ram needed to map the faxes.

The MappingMultiplier variable has a goal: The larger the number and the finer the rendered fax is. A small number means pixellated rendering but smaller ram occupation.

As I remapped nearly everything I tried to enlarge the MappingMultiplier each time to get beautiful rendering but I didn't think it would be an issue on several modest devices. It's mainly my fault as my computer is rather powerful.

I am keen to make a new "low powered" CoordinateSets.xml and keep the actual one for devices that can support it.
That would be great if there was an option to choose.

What do you think Rick ?

@rgleason
Copy link
Owner Author

rgleason commented Jun 10, 2022

@ozolli
I think it would be quite easy to manually support two coordinateSets.xml resolutions.
The low res version would be the default.
The user can then chose to copy over the low res version.
I would suggest distributing

  • CoordinateSets.xml (default is low res)
  • CoordinateSets-low.xml
  • CoordinateSets-high.xml

Then to get high-res a user has to copy CoordinateSets-high.xml over CoordinateSets.xml
and also delete the coordinateSets.xml in the user directory, and then restart O.
Later we can enhance this feature and add a control in Preferences.

@ozolli
Copy link

ozolli commented Jun 10, 2022

Yes I agree.

@rgleason
Copy link
Owner Author

rgleason commented Jun 16, 2022

@ozolli We are going to be rebuilding all the TP plugins for additional OS. If you can send or attach the two coordinateSets.xml files to be included, that would be very helpful. (I have about 20 plugins to do, but this is going to be done quite quickly, I hope, so I will need them in the next couple of days. Thanks so much.)

  • CoordinateSets.xml (default is normal res)
  • CoordinateSets-normal.xml
  • CoordinateSets-high.xml

@ozolli
Copy link

ozolli commented Jun 16, 2022

Rick I'm not sure I will have the time to implement the whole low res file in this time frame...
There are some faxes like the NOAA GOES that don't have coordinates grid so mapping them is quite a long task to achieve a proper result.
I'll do my best.

@rgleason
Copy link
Owner Author

Thanks so much, 4-5 days would be ok to. Leaving on a cruise next Wed.

@ozolli
Copy link

ozolli commented Jun 18, 2022

Here we are :
CoordinateSets-normal.zip
CoordinateSets-high.zip
I hope there is no mistake...

@rgleason
Copy link
Owner Author

Me too. Thanks so much! Will push to prod and plugins Master Catalog!
I could not or did not have the time to figure out how you get the coordinates with these.

@rgleason
Copy link
Owner Author

I am going to close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants