Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wget shows up as a phone #41

Closed
reality opened this issue Mar 10, 2016 · 3 comments
Closed

wget shows up as a phone #41

reality opened this issue Mar 10, 2016 · 3 comments

Comments

@reality
Copy link

reality commented Mar 10, 2016

Thanks for your useful library, however there is one small issue: wget seems to be interpreted as a 'phone,' and I think it should be a 'bot.' Here is what I get when wgetting a simple page which simply res.sends the req.device:

{"parser":{"options":{"emptyUserAgentDeviceType":"desktop","unknownUserAgentDeviceType":"phone","botUserAgentDeviceType":"bot","carUserAgentDeviceType":"car","parseUserAgent":true},"useragent":{"family":"Wget","major":"1","minor":"16","patch":"3","device":{"family":"Other","major":"0","minor":"0","patch":"0"},"os":{"family":"Other","major":"0","minor":"0","patch":"0"}}},"type":"phone","name":"Other"} 

If I perform the same experiment using curl, then it correctly returns as a bot.

This was tested using: express-device@0.4.2 useragent@2.1.8 and express@4.9.8

@rguerreiro
Copy link
Owner

Thanks for the feedback. I'll look into it

@rguerreiro
Copy link
Owner

Moved the issue to the device repo, since this functionality it's now implemented on that package

@rguerreiro
Copy link
Owner

New version (0.3.5) of device published to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants