Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIGABRT when press 'next' btn with subprocess.CalledProcessError #288

Open
ignatenkobrain opened this issue Sep 9, 2015 · 1 comment
Open

Comments

@ignatenkobrain
Copy link
Contributor

Related to #285. If I will press 'next' with %py3_build field -- RPG will not just ignore error, it will crash with SIGABRT.

[16:54:48] {/home/brain/git/upstream/rpg/rpg/project_builder.py:13} DEBUG - build(PosixPath('/tmp/rpg-appdirs-1.4.0.tar.gz-a23245a/extracted'), PosixPath('/tmp/rpg-appdirs-1.4.0.tar.gz-a23245a/compiled'), Command('%py3_build'))
/bin/sh: line 0: fg: no job control
Traceback (most recent call last):
  File "/home/brain/git/upstream/rpg/rpg/gui/wizard.py", line 395, in validatePage
    self.base.build_project()
  File "/home/brain/git/upstream/rpg/rpg/__init__.py", line 229, in build_project
    self.spec.build)
  File "/home/brain/git/upstream/rpg/rpg/project_builder.py", line 19, in build
    build_command.execute_from(project_target_dir)
  File "/home/brain/git/upstream/rpg/rpg/command.py", line 55, in execute_from
    return cmd_output(command_lines)
  File "/home/brain/git/upstream/rpg/rpg/command.py", line 62, in cmd_output
    output = check_output(["/bin/sh", "-c", " && ".join(cmdlines)])
  File "/usr/lib64/python3.4/subprocess.py", line 620, in check_output
    raise CalledProcessError(retcode, process.args, output=output)
subprocess.CalledProcessError: Command '['/bin/sh', '-c', 'cd /tmp/rpg-appdirs-1.4.0.tar.gz-a23245a/compiled && %py3_build']' returned non-zero exit status 1
[16:54:57] {/home/brain/git/upstream/rpg/rpg/project_builder.py:13} DEBUG - build(PosixPath('/tmp/rpg-appdirs-1.4.0.tar.gz-a23245a/extracted'), PosixPath('/tmp/rpg-appdirs-1.4.0.tar.gz-a23245a/compiled'), Command('%py3_build'))
/bin/sh: line 0: fg: no job control
Traceback (most recent call last):
  File "/home/brain/git/upstream/rpg/rpg/gui/wizard.py", line 395, in validatePage
    self.base.build_project()
  File "/home/brain/git/upstream/rpg/rpg/__init__.py", line 229, in build_project
    self.spec.build)
  File "/home/brain/git/upstream/rpg/rpg/project_builder.py", line 19, in build
    build_command.execute_from(project_target_dir)
  File "/home/brain/git/upstream/rpg/rpg/command.py", line 55, in execute_from
    return cmd_output(command_lines)
  File "/home/brain/git/upstream/rpg/rpg/command.py", line 62, in cmd_output
    output = check_output(["/bin/sh", "-c", " && ".join(cmdlines)])
  File "/usr/lib64/python3.4/subprocess.py", line 620, in check_output
    raise CalledProcessError(retcode, process.args, output=output)
subprocess.CalledProcessError: Command '['/bin/sh', '-c', 'cd /tmp/rpg-appdirs-1.4.0.tar.gz-a23245a/compiled && %py3_build']' returned non-zero exit status 1
Aborted (core dumped)
@jsilhan
Copy link
Member

jsilhan commented Sep 9, 2015

We could catch such exceptions at the wizard, exit and print log.critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants