Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation for rosa cluster subnets input #29

Open
scottd018 opened this issue Jul 18, 2023 · 1 comment
Open

fix: add validation for rosa cluster subnets input #29

scottd018 opened this issue Jul 18, 2023 · 1 comment

Comments

@scottd018
Copy link
Contributor

The following logic needs to be added to the CRD CEL expression list for a ROSACluster resource:

  • For a public multi-az cluster with provided subnets, 6 subnets should be provided (3 private, 3 public)
  • For a public single-az cluster with provided subnets, 2 subnets should be provided (1 public, 1 private)
  • For a private-link multi-az cluster with provided subnets, 3 subnets should be provided (3 private)
  • For a private-link single-az cluster with provided subnets, 1 subnet should be provided (1 private)

Additionally, validation should happen as part of the reconciler logic to ensure anything that CRD CEL cannot validate does not make it too far into cluster creation:

  • For a public cluster with provided subnets, there should be 2 subnets per AZ
  • For a private-link cluster with provided subnets, there should be 1 subnet per AZ

The above needs to happen as part of the AWS client workflow (for now).

@paulczar
Copy link

mostly correct! the function that fetches the AZs for the subnets should always supply the number of AZs correctly (1 or 3) therefore the list should be uniquified, otherwise for a public cluster you'll have each AZ in the list twice because of the public AND private subnets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants