Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded 0044 from for Adoptium on java 19 #39

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

RadekCap
Copy link
Collaborator

@RadekCap RadekCap commented Mar 9, 2023

Excluded this test to not fail pipelines like this - https://github.com/rh-openjdk/WindowsTPS/actions/runs/4365175766

It'll be fixed in #24 or #35.

Closes #35

@zzambers
Copy link
Contributor

zzambers commented Mar 10, 2023

By looking at test code bellow your changes, I got impression that path was changed in JDK17 from ${JAVA_INSTALL_DIR}\\lib\\server to ${JAVA_INSTALL_DIR}\\bin\\server. But exact version is tested.

I think better fix would probably be changing [[ $OTOOL_JDK_VERSION -eq 17 ]] to [[ $OTOOL_JDK_VERSION -ge 17 ]].

@RadekCap RadekCap merged commit 9582855 into main Mar 14, 2023
@RadekCap RadekCap deleted the exclude_044_for_Adoptium_19 branch April 4, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ojdk 19 into pipeline
2 participants