Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parentage information #17

Closed
rhagenson opened this issue Nov 12, 2019 · 5 comments
Closed

Allow parentage information #17

rhagenson opened this issue Nov 12, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@rhagenson
Copy link
Owner

Separate, but related to #4, is allowing one to input any suspected parentage calls and have them validated via relatedness and, if relatedness agrees, have the pedigree show parent above offspring.

In addition, it would be best if in the pedigree any suspected parentage that was confirmed via relatedness was formatted slightly differently from the inferred parentage. I would expect using a tool such as this one would be more interested in the points of where suspected did not match observed, as well as where the inference occurred -- therefore those matching suspected relationships could be formatted to be mildly translucent or be formatted smaller than inferences.

@rhagenson rhagenson added the enhancement New feature or request label Nov 12, 2019
@rhagenson
Copy link
Owner Author

As stated in #4 (comment):

Point of warning: When demographic information disagrees with relatedness/relational distance calls, the latter should be preferred and a warning about the disagreement returned to the user. This scenario is possible in the case of belief that two individuals are PO, when according to relatedness they are FS. When the two agree, there should be some visual difference in the pedigree to denote that the expected was the same as observed -- perhaps boxing such relationships together would suffice?

@rhagenson
Copy link
Owner Author

@ThatLionLady and I agreed that the format for this input should be

ID Sire Dam
(uint;string) (uint;string) (uint;string)

If using demographic information (#4), the Sire should be Male and Dam should be Female -- if either is Unknown (not both) then I need to make a decision on whether I infer the Sex or keep it as Unknown. Better yet, I could print Info messages when making inferences and denote any node with inference of any kind with a * appended to the name (which shouldn't break Graphviz).

@rhagenson
Copy link
Owner Author

Attention: Make parentage supersede the relatedness input.

@rhagenson
Copy link
Owner Author

Attention: If both parentage and demographics input is used, fail if they do not agree with one another.

@rhagenson
Copy link
Owner Author

Fails if the two demographics and parentage disagree (see 175e270).

Parentage superseding relatedness happens strictly via the path finding of the graph.

Still remaining is accounting for the magic values of 0 and ? to denote an unknown sire or dam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant