Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure codified entries always remain #43

Open
rhagenson opened this issue Mar 16, 2020 · 0 comments
Open

Ensure codified entries always remain #43

rhagenson opened this issue Mar 16, 2020 · 0 comments

Comments

@rhagenson
Copy link
Owner

As identified during review by openjournals/joss-reviews#2124 (comment), relped is currently dropping some codified entries such as half-siblings. I am uninterested in precisely "why" these relationships are being dropped as I suspect it is a case of pruning and the order that pruning happens to occur in for a particular iteration.*

What is important here is to match user expectation where if they have entered a code, then that connection should always exist in the final pedigree network.

*: If two paths have the same weight because they were both drawn from the same code relped during pruning selects the "highest weight" path then drops the others even if equally weighted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant