Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing shim reviews and the 15.8 release #364

Closed
jason-rodri opened this issue Jan 24, 2024 · 6 comments
Closed

Existing shim reviews and the 15.8 release #364

jason-rodri opened this issue Jan 24, 2024 · 6 comments
Labels
meta Not a review request, but an issue or notice wrt the signing process

Comments

@jason-rodri
Copy link

I have a question concerning organizations who have outstanding 15.7 shim reviews and how we should approach the 15.8 shim release.

Should we update our existing 15.7 reviews with the 15.8 release or should we create an additional review for the 15.8 release?

With the 15.8 release now public will an existing 15.7 shim review be approved?

@kukrimate
Copy link
Contributor

15.8 fixes security issues, no more 15.7 shims should be signed.

@enriched
Copy link

@kukrimate thank you for clarifying that. Do you know if updating the current review would be acceptable, or are people typically asked to create a new review?

@SherifNagy
Copy link
Collaborator

I would say opening a new submission will make everyone's life easier, but that's my personal preference

@aronowski aronowski added the meta Not a review request, but an issue or notice wrt the signing process label Jan 31, 2024
@jsetje
Copy link
Collaborator

jsetje commented Feb 15, 2024

I'd like to propose that all 15.7 based submissions be closed asking for a 15.8 based one. One of the CVEs addressed in 15.8 has a disturbingly high score and I could see revocations for 15.7 becoming mandatory at some point the future, potentially without much advance notice.

@THS-on
Copy link
Collaborator

THS-on commented Feb 20, 2024

@jsetje now went through the submissions asking people either to update or create new ones.

If they don't respond in a timely fashion, I'll close them.

@THS-on
Copy link
Collaborator

THS-on commented Feb 29, 2024

everybody seems now to have responded to the updating requests, therefore closing this one

@THS-on THS-on closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Not a review request, but an issue or notice wrt the signing process
Projects
None yet
Development

No branches or pull requests

7 participants