Add explicit access token invalidation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2015 09:46
An access token is invalidated by setting its expiration date to 1 January 1970, GMT. Closes #40.
| /// | ||
| /// :returns: A new access token with this access token's values for | ||
| /// properties where new ones are not provided. | ||
| public func copy(accessToken: String? = nil, tokenType: String? = nil, expiresAt: NSDate?? = nil, refreshToken: String?? = nil) -> OAuthAccessToken { |
There was a problem hiding this comment.
Missing tests for public function
|
There is a slight feeling of this being a hack and thoughts about adding something like |
|
Agreed, adding state would certainly be less hacky. |
|
However, we would have to store that state and it's kind of non-spec. |
|
Right. I think storing it internally wouldn't be a problem though because we don't differ from the spec in our external behavior. |
tibr
added a commit
that referenced
this pull request
Feb 23, 2015
…token Add explicit access token invalidation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An access token is invalidated by setting its expiration date to 1 January 1970, GMT.
Closes #40.