Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 and our chunking system #17

Closed
ScriptedAlchemy opened this issue May 28, 2018 · 10 comments
Closed

Webpack 4 and our chunking system #17

ScriptedAlchemy opened this issue May 28, 2018 · 10 comments
Assignees

Comments

@ScriptedAlchemy
Copy link

Might help you bro!

faceyspacey/extract-css-chunks-webpack-plugin#60

@rherwig
Copy link
Owner

rherwig commented May 28, 2018

@zackljackson Thanks a lot! I'll have a look. Would be nice to have working CSS chunks once again :-)

@ScriptedAlchemy
Copy link
Author

It’s already done ✅ just updating readmes and cleaning a bunch of stuff up. Beta testing and feedback would be valuable ❤️🙏 PRs are also welcome if you spot something off the bat

Main thing is I want awesome chunking back 😂 its a massive re-rewrite so beta testing is important.

There’s almost half a million installs 😆 safety first

@rherwig
Copy link
Owner

rherwig commented May 28, 2018

I'm taking a look at it right this evening and will of course submit feedback

@zackkirsh
Copy link

Awesome, ill be pushing commits throughout the day, just drop a line if you have a question

@rherwig
Copy link
Owner

rherwig commented May 28, 2018

I tried to implement the version from your current webpack-4 branch and ran into a build-time issue.

I basically set it up like your documentation says, which mainly involves the webpack config:
https://github.com/rherwig/template-react-16-ssr/blob/development/webpack/client.js

Everything but HMR works with mini-extract-css-chunks. If you want to take a look at the issue, please refer to the development branch of this repository :-)

@ScriptedAlchemy
Copy link
Author

Found it. Gimme a few

@ScriptedAlchemy
Copy link
Author

ScriptedAlchemy commented May 28, 2018

Okay done, should work for you now. Thanks for beta testing! Ill need to write tests for this.

Pretty much it was expecting use: to be an array. Stupid mistake on my part

@rherwig
Copy link
Owner

rherwig commented May 28, 2018

Yay! It works now! :-) Thanks for the effort so far, I'm gonna go on and test it a little more now

@ScriptedAlchemy
Copy link
Author

Fantastic!! More than welcome.

If you have some spare time. Id greatly appreciate it if you can add / extend a test to prevent this happening.

Let me know if you spot anything else

@rherwig rherwig self-assigned this May 28, 2018
@ScriptedAlchemy
Copy link
Author

Aaaaaaand it’s releaeed! V3.x.x is on npm 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants