Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: consider storing imageDate as ISO format string instead of datetime object #45

Closed
RhetTbull opened this issue Jan 2, 2020 · 2 comments
Closed

Change: consider storing imageDate as ISO format string instead of datetime object #45

RhetTbull opened this issue Jan 2, 2020 · 2 comments
Labels
feature request New feature or request

Comments

@RhetTbull
Copy link
Owner

This would make it easier to directly serialize PhotoInfo._info as JSON, etc. Is there a performance impact?
@RhetTbull RhetTbull added the feature request New feature or request label Jan 2, 2020
@RhetTbull
Copy link
Owner Author

Addition of from_date, to_date to PhotosDB.photos means this issue would likely add a performance hit. May instead add a serializer for _info for debugging use.

@RhetTbull
Copy link
Owner Author

I've decided to leave the implementation as is. Should probably eventually add a json serializer for __info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RhetTbull