Skip to content

Commit

Permalink
Use the return of findActiveDevicesOnActionDisks() properly
Browse files Browse the repository at this point in the history
The function findActiveDevicesOnActionDisks() does return a list of
device names, i.e. a list of strings, not a list of devices.

Without this fix, an AttributeError is throwned before the RuntimeError,
see:

  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 354, in processActions
    self._preProcessActions()
  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 258, in _preProcessActions
    ",".join(p.name for p in problematic))
  File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 258, in <genexpr>
    ",".join(p.name for p in problematic))
AttributeError: 'str' object has no attribute 'name'
  • Loading branch information
mopsfelder committed May 20, 2015
1 parent 78ccc42 commit de89a34
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion blivet/devicetree.py
Expand Up @@ -255,7 +255,7 @@ def _preProcessActions(self):
else:
raise RuntimeError("partitions in use on disks with changes "
"pending: %s" %
",".join(p.name for p in problematic))
",".join(problematic))

log.info("resetting parted disks...")
for device in self.devices:
Expand Down

0 comments on commit de89a34

Please sign in to comment.