Master btrfs a #107
Closed
Master btrfs a #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Externally to the mountsCache it seems that sometimes the subvolspec is a str, sometimes an int. Make mountsCache store and retrieve treating subvolspec always as a str. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
It is possible that /proc/self/mountinfo changes during execution of _getActiveMounts, but it is also possible that /proc/mounts changes, and we do not guard against that. The motivation behind this is that it is expensive to parse on average half the file for some supplementary information about btrfs everytime it is needed. The downside of this cacheing is that a data structure gets held in memory for the duration of _getActiveMounts execution, although this only happens if btrfs info is requested. Also, there is a slight improvement in the way the slightly variable format data in mountinfo is parsed. Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes PR#105.
First two patches are very minor.
"Make mountsCache..." and "Make default subvolspec" are substantially as before."
"Use context manager..." and "Cache mountinfo..." are new.