Store vendor/model information for DiskDevice instances. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if desc: | ||
| desc += " " | ||
| desc += self.model | ||
| return desc |
There was a problem hiding this comment.
" ".join(s for s in (self.vendor, self.model) if s)
seems clearer to me.
|
Looks good, then. |
|
Looks good to me too. |
Also make sure _model and _vendor attrs are never set to None in the StorageDevice constructor. Fixes storaged-project#84
dwlehman
force-pushed
the
disk-model-branch
branch
from
9b56e89
to
0671839
Compare
dwlehman
added a commit
that referenced
this pull request
May 26, 2015
Store vendor/model information for DiskDevice instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make sure _model and _vendor attrs are never set to None in the
StorageDevice constructor.
Fixes #84