Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid access to a name attribute on device name strings. #117

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented May 18, 2015

The findActiveDevicesOnActionDisks method returns a list with the names
(strings) of the active devices. There is not a 'name' attribute to be
accessed.

@mulkieran mulkieran added the ACK label May 18, 2015
@mulkieran
Copy link
Contributor

Bug is present in f21 also.

@dwlehman
Copy link
Contributor

dwlehman commented Jun 4, 2015

This was closed by accident when we did some branch management. rhel7-branch has moved, so you'll have to reset your local branch.

@dwlehman dwlehman reopened this Jun 4, 2015
@ghost
Copy link
Author

ghost commented Jun 4, 2015

@dwlehman could you please clarify? Has branch rhel7-branch been abandoned?
Ou should I simply do a rebase?

@dwlehman
Copy link
Contributor

dwlehman commented Jun 4, 2015

What was rhel7-branch prior to last Friday has been abandoned. The new rhel7-branch was created on the same day (Fri 29 May 2015) and is active. What you'll have to do, I think, is update your local rhel7-branch and then rebase your commit.

@ghost
Copy link
Author

ghost commented Jun 4, 2015

I see; tried the rebase and got a few merge conflicts.

I'll look into it, though.

The findActiveDevicesOnActionDisks method returns a list with the names
(strings) of the active devices. There is not a 'name' attribute to be
accessed.
@ghost
Copy link
Author

ghost commented Jun 4, 2015

Branch updated.

@dwlehman
Copy link
Contributor

It occurs to me only now that there are stringent restrictions on what can be pushed to rhel7-branch. To get this pushed there we will need a bugzilla bug report, which will need to be approved for inclusion in a specific release of RHEL-7.

If this is an issue on master, however, we would be quite happy to apply the fix there.

@mulkieran mulkieran removed their assignment Jun 23, 2015
@mulkieran
Copy link
Contributor

This is fixed on master.

@mopsfelder
Copy link

@dwlehman how do we open a bugzilla for this to be fixed in RHEL 7?

@dwlehman
Copy link
Contributor

@mopsfelder sorry for the massive delay in answering -- I totally missed your question.

To get this onto rhel7-branch you would need to make a request through your Red Hat support contact. If you don't have one, you could just open a bug at bugzilla.redhat.com.

@mopsfelder
Copy link

@dwlehman Thank you for responding (even though almost 2 years later).

This issue is not in our radar anymore, i.e. we will not chase it down. Feel free to close or apply it.

@dwlehman dwlehman closed this Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants