Use the return of findActiveDevicesOnActionDisks() properly #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function findActiveDevicesOnActionDisks() does return a list of
device names, i.e. a list of strings, not a list of devices.
Without this fix, an AttributeError is throwned before the RuntimeError,
see:
File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 354, in processActions
self._preProcessActions()
File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 258, in _preProcessActions
",".join(p.name for p in problematic))
File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 258, in <genexpr>
",".join(p.name for p in problematic))
AttributeError: 'str' object has no attribute 'name'
|
This is a dupe of #117. Closing it, but fix will go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function findActiveDevicesOnActionDisks() does return a list of
device names, i.e. a list of strings, not a list of devices.
Without this fix, an AttributeError is throwned before the RuntimeError,
see:
File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 354, in processActions
self._preProcessActions()
File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 258, in _preProcessActions
",".join(p.name for p in problematic))
File "/usr/lib/python2.7/site-packages/blivet/devicetree.py", line 258, in
",".join(p.name for p in problematic))
AttributeError: 'str' object has no attribute 'name'