Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put translations into a subpackage shared by Python 2 and 3 #126

Merged

Conversation

vpodzime
Copy link
Contributor

With providing both Python 2 and Python 3 packages we need to make sure both
have the translations available. This commit makes the translations shared by
both Python 2 and 3 subpackages by putting them into a separate subpackage
required by both.

@dwlehman dwlehman added the ACK label Jun 18, 2015
@vpodzime vpodzime force-pushed the master-translations_subpackage branch from 48e87f4 to 733acf7 Compare July 27, 2015 14:25
@dashea
Copy link
Contributor

dashea commented Jul 27, 2015

Shouldn't the Requires for blivet-data be matched by version?

This is kind of one of those things where it would be nice if the Fedora package committee came up with some recommendations, because all the solutions are haphazard and gross. I'm not real keen on the idea of a new package to begin with, and if you match the python3?-blivet version to the blivet-data version, which I think it should be, then if you have python-blivet and python3-blivet on the same system then those versions would need to match too, which isn't terrible but is kind of weird.

The solution a lot of packages seem to be using, including pykickstart, is to install the .mo files into the python directory, something like site-packages/blivet/locale.

@vpodzime
Copy link
Contributor Author

Yeah, I think the version should be matched. I'll fix this as I think it's a "lesser evil" when compared to the version mismatch between the data package and the code.

Generally, the idea is to have these files in the system only once. And if we need some more "non-code" stuff in the future (like a config file or something), it should go into this subpackage.

@vpodzime vpodzime force-pushed the master-translations_subpackage branch 2 times, most recently from 528e81c to a22a7a8 Compare July 28, 2015 14:31
With providing both Python 2 and Python 3 packages we need to make sure both
have the translations available. This commit makes the translations shared by
both Python 2 and 3 subpackages by putting them into a separate subpackage
required by both.
@vpodzime vpodzime force-pushed the master-translations_subpackage branch from a22a7a8 to 44568ea Compare July 28, 2015 14:35
@vpodzime
Copy link
Contributor Author

A new version rebased to master and correctly requiring the exact same version (epoch:version-release) of the blivet-data package.

vpodzime added a commit that referenced this pull request Jul 28, 2015
Put translations into a subpackage shared by Python 2 and 3
@vpodzime vpodzime merged commit bd0b71d into storaged-project:master Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants