Adapt to the new libblockdev initialization API #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except GLib.GError: | ||
| pass | ||
| try: | ||
| succ, avail_plugs = blockdev.try_reinit(require_plugins=_requested_plugins, reload=False, log_func=log_bd_message) |
There was a problem hiding this comment.
succ is ignored, so it should be underscored.
There was a problem hiding this comment.
Good catch, thanks! I originally meant to use it to skip the set operations and checks, but I think it's clearer to just compare the sets. Fixing.
|
Other than comment about "succ", it looks fine to me. |
vpodzime
force-pushed
the
master-libblockdev_1.0
branch
from
5b6ec37
to
fd59029
Compare
In version 1.0 the libblockdev library changes the initialization functions a bit and thanks to that we may simplify our code.
vpodzime
force-pushed
the
master-libblockdev_1.0
branch
from
fd59029
to
8e31f6d
Compare
|
Added the underscore to the |
vpodzime
added a commit
that referenced
this pull request
May 27, 2015
Adapt to the new libblockdev initialization API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.0 the libblockdev library changes the initialization functions a
bit and thanks to that we may simplify our code.