Allow adding new partitions to disks with active devices #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me with the second commit (19cd03c) added. |
|
Just one more thing -- please add the 'cherry-picked from ....' lines to the commit messages (and consider using |
Parted doesn't allow changing disklabel when there is an active partition on the disk. Current implementation of findActiveDevicesOnActionDisks doesn't allow adding new partitions when there is an existing active (child) device other than another partition (eg. VG). New version checks only actions that actually changes the disklabel and checks status of formats of (child) devices on the disk with changes. (cherry picked from commit b72e957) Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
LVMPhysicalVolume format should be True (active) if exists and if has an existing VG. (cherry picked from commit de7b86c) Signed-off-by: Vojtech Trefny <vtrefny@redhat.com>
vojtechtrefny
force-pushed
the
f22-branch-fix_active_parted
branch
from
19cd03c
to
21f02d5
Compare
vojtechtrefny
added a commit
that referenced
this pull request
Jun 2, 2015
Allow adding new partitions to disks with active devices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#93 for f22-branch