More followups for size property changes #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to a recent change in which I added a call to the superclass size setter from thinlv's size setter.
The format type can impose limits on the size of the device, so clear it before setting the size.
If the device ends up smaller than the format's min size we must have run out of space. It's only okay for the device size to end up the format's min size if that's what was asked for, whether explicitly or by normalizing the specified target size.
|
These all look good to me. |
dwlehman
added a commit
that referenced
this pull request
Jul 27, 2015
More followups for size property changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kellinm The ones you're interested in are a5000d4, a800128, and b8b2c48